Fix syntax in a workflow - #790
Merged
adityasharad merged 1 commit intoOct 22, 2021
Merged
adityasharad merged 1 commit into
adityasharad merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
3 tasks
adityasharad
approved these changes
Oct 22, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks right, the if block is special in that it doesn't require ${{ }}.
Sorry, something went wrong.
edoardopirovano
enabled auto-merge
October 22, 2021 16:45
aeisenberg
reviewed
Oct 22, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks right. If we wanted to keep the optional ${{ ... }} I think we'd want it to wrap the entire expression, not just part of it.
Sorry, something went wrong.
edoardopirovano
disabled auto-merge
October 22, 2021 16:47
Copy link
Copy Markdown
Contributor
Author
|
This will need force merging as it is running the broken workflow from main. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix the logic added in #789 since some runs appear to not be doing the right thing, e.g. https://github.com/github/codeql-action/runs/3977974129?check_suite_focus=true