Make the temporary directory in tests a symlink - #80
Merged
robertbrignull merged 1 commit intoJun 24, 2020
Merged
robertbrignull merged 1 commit into
robertbrignull merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sampart
approved these changes
Jun 24, 2020
sampart
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good addition, thanks.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a problem when the code was run under a directory that contained a symlink. It was fixed in #67
This PR hopes to avoid re-introducing a bug like that by making the directory returned by withTmpDir be a symlink to another directory. I've tested this by reverting #67 to reintroduce the bug and it fails in exactly the way we were seeing before.
Merge / deployment checklist