Include matrix information in debug artifact name - #809
aeisenberg merged 1 commit into
Conversation
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
The uploaded artifacts look good. Is there any reason why we're not running these tests using windows?
Sorry, something went wrong.
| let suffix = ""; | ||
| const matrix = actionsUtil.getRequiredInput("matrix"); | ||
| if (matrix !== undefined && matrix !== "null") { | ||
| for (const entry of Object.entries(JSON.parse(matrix)).sort()) |
There was a problem hiding this comment.
How does sort work if the keys are arrays? I did a little test and it seems to work. Also, we only need this functionality to ensure our tests work, so even if the sorting is not stable, if our tests pass consistently, I'm not too worried.
Sorry, something went wrong.
There was a problem hiding this comment.
I believe the default way to compare two arrays in TypeScript is lexicographically. Since in this case the first element is the key of a JSON map, we know that all the arrays will differ in their first element (since the keys must be unique), so this is equivalent to sorting by the name of the key.
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
Meant to approve the first time, but clicked the wrong button. :)
Sorry, something went wrong.
Only that the bash script that checks the result wouldn't work on Windows (I think). |
Sorry, something went wrong.
Adds the contents of matrix to the name of the debug artifact to avoid issues with clashing names in matrixed runs.