Upgrade AVA to v4 - #822
Merged
henrymercer merged 5 commits intoFeb 2, 2022
Merged
henrymercer merged 5 commits into
henrymercer merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
2 times, most recently
from
b684105 to
9c43038
Compare
November 23, 2021 11:33
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
3 times, most recently
from
95327cd to
829cdb3
Compare
December 10, 2021 21:42
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
2 times, most recently
from
9846f42 to
10b0d81
Compare
January 18, 2022 22:22
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
2 times, most recently
from
d4bb43c to
427ceab
Compare
January 24, 2022 13:35
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
5 times, most recently
from
d3a91ad to
abe8e36
Compare
January 31, 2022 21:39
Bumps [@ava/typescript](https://github.com/avajs/typescript) from 2.0.0 to 3.0.1. - [Release notes](https://github.com/avajs/typescript/releases) - [Commits](avajs/typescript@v2.0.0...v3.0.1) --- updated-dependencies: - dependency-name: "@ava/typescript" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
from
abe8e36 to
1163942
Compare
February 1, 2022 13:33
henrymercer
marked this pull request as draft
February 1, 2022 17:46
henrymercer
marked this pull request as ready for review
February 1, 2022 17:46
henrymercer
force-pushed
the
dependabot/npm_and_yarn/ava/typescript-3.0.1
branch
from
3273370 to
ce89f1b
Compare
February 1, 2022 18:56
Copy link
Copy Markdown
Contributor
|
@github/codeql-action-reviewers I needed to make some changes to the Action codebase, e.g. adding type annotations, converting macros to use the typed versions, modifying Eslint configuration, to upgrade to AVA 4. Therefore I can't reasonably review this PR myself. Please could one of you take a look? |
Sorry, something went wrong.
aeisenberg
approved these changes
Feb 2, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for taking this on. Looks good to me.
So, it seems like for ava > 4, a failing assertion does not end the test, which is a nice feature (I think).
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @ava/typescript from 2.0.0 to 3.0.1.
Release notesSourced from @ava/typescript's releases.
CommitsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: