FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix dotnet prompting for user input by robertbrignull · Pull Request #833 · github/codeql-action · GitHub

/ codeql-action Public

Fix dotnet prompting for user input - #833

Merged
robertbrignull merged 1 commit into
mainfrom
robertbrignull/fix-dotnet
Dec 6, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Fix dotnet prompting for user input#833
robertbrignull merged 1 commit into
mainfrom
robertbrignull/fix-dotnet

Conversation

robertbrignull commented Dec 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

A few CI checks are currently failing because dotnet is waiting for some user-input. e.g. https://github.com/github/codeql-action/runs/4381100962?check_suite_focus=true

This seems to be because of a change in the CodeQL CLI and how it handles dotnet under tracing in macos. This may get fixed in CodeQL but for now a workaround to get our CI working is to call dotnet restore when not traced by CodeQL so it can do it's first-time setup without interference.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

robertbrignull requested a review from a team as a code owner December 3, 2021 10:49
robertbrignull changed the title Opt out of dotnet telemetry Deal with new dotnet version Dec 3, 2021
robertbrignull force-pushed the robertbrignull/fix-dotnet branch 3 times, most recently from 7213e56 to c1b9717 Compare December 3, 2021 12:44
robertbrignull force-pushed the robertbrignull/fix-dotnet branch from c1b9717 to f721f01 Compare December 6, 2021 09:43
edoardopirovano approved these changes Dec 6, 2021
View reviewed changes

edoardopirovano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New change LGTM. I wonder whether it might be easier to have sync.py insert that call at the start of every workflow. Needn't be done in this PR, though - for now let's get this merged to unblock our tests.

robertbrignull commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

New change LGTM. I wonder whether it might be easier to have sync.py insert that call at the start of every workflow. Needn't be done in this PR, though - for now let's get this merged to unblock our tests.

Thanks. I also think it would be better to just get it working for now. Having sync.py add that sounds nice, and would fit in with work on reducing the parallelism too.

edoardopirovano commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Thanks. I also think it would be better to just get it working for now. Having sync.py add that sounds nice, and would fit in with work on reducing the parallelism too.

Agreed, I can look at doing that when I'm working on sync.py anyway. For now, let's get our CI working again 🙂

robertbrignull commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

CI is passing so this looks like it works

robertbrignull merged commit a82f53a into main Dec 6, 2021
robertbrignull deleted the robertbrignull/fix-dotnet branch December 6, 2021 09:59
robertbrignull changed the title Deal with new dotnet version Fix dotnet prompting for user input Dec 6, 2021
github-actions Bot mentioned this pull request Dec 6, 2021
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
edoardopirovano edoardopirovano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL