Stop printing all output twice. - #844
Merged
chrisgavin merged 2 commits intoDec 13, 2021
Merged
chrisgavin merged 2 commits into
chrisgavin merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Here's a somewhat noisy but hopefully still useful diff showing the effect of the change on a JavaScript build. https://www.diffchecker.com/GQYzoaIw |
Sorry, something went wrong.
hmakholm
approved these changes
Dec 9, 2021
chrisgavin
enabled auto-merge
December 13, 2021 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing some reason for this code existing, but it feels like all it does is duplicate the extractor output in the Actions logs. Can we remove it or have I missed something here?
Merge / deployment checklist