FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove debugging output by edoardopirovano · Pull Request #861 · github/codeql-action · GitHub

Remove debugging output - #861

Merged
edoardopirovano merged 2 commits into
mainfrom
remove-debug-output
Jan 2, 2022
Merged

edoardopirovano merged 2 commits into
mainfrom
remove-debug-output

Conversation

Copy link
Copy Markdown
Contributor

Looks like I accidentally committed some debugging output when I wrote this part of our CI. This PR removes it.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

edoardopirovano requested a review from a team as a code owner December 31, 2021 16:32
aeisenberg enabled auto-merge January 1, 2022 17:11
aeisenberg disabled auto-merge January 1, 2022 22:49

Copy link
Copy Markdown
Contributor

That's wild. Looks like failures on Python 2 on macos. Rerunning on main to see if this is a general problem: https://github.com/github/codeql-action/actions/runs/1633534088

Copy link
Copy Markdown
Contributor

Yep. Same jobs are failing on main. This must be related to some changes to the python 2 version that is bundled in the virtual environment. Will look deeper when I am back at work.

edoardopirovano commented Jan 1, 2022
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hmm, strange. I can't imagine this change causing any test failures so it's probably something that is failing on main too. Maybe a change to the Python version in the Mac OS Actions image is causing the test failures?

Edit: yep, what you said while I typed that haha

aeisenberg commented Jan 2, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

Here is the most recent passing job: https://github.com/github/codeql-action/runs/4668380714?check_suite_focus=true

You can see that the image used in the passing workflow is the same as the one used in the failing workflow. So, it must be some sort of python transitive dependency that has changed. This will be fun to track down.

Copy link
Copy Markdown
Contributor

Difference is the version of virtualenv. For the passing job, it is 20.11.2. For the failing job, it is 20.12.1.

So, looks like we need to force virtualenv@20.11.2 for python 2 tests.

Copy link
Copy Markdown
Contributor

Let's see if this works. #862

Copy link
Copy Markdown
Contributor Author

Sweet, thanks for fixing that!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL