Make name of debugging artifact and DB within it configurable - #868
edoardopirovano merged 1 commit into
Conversation
Sorry, something went wrong.
robertbrignull
left a comment
There was a problem hiding this comment.
Thanks for the ping. The remote queries changes LGTM.
Sorry, something went wrong.
| config.dbLocation, | ||
| `${databasePath}.zip` | ||
| ); | ||
| const databaseBundlePath = path.resolve(config.dbLocation, `${dbName}.zip`); |
There was a problem hiding this comment.
So, this will now place the bundled db in a different location? I don't think that's a problem, but it is a change and just want to be sure.
Sorry, something went wrong.
There was a problem hiding this comment.
Indeed, that is correct. I hope there's no code outside the codeql-action that is relying on where we happen to put the DB bundles before uploading them to an artifact. I don't think that's a use-case we've ever claimed to support, nor do I think we should be supporting it, so I think it is okay to break.
Sorry, something went wrong.
As requested by @esbena and @hvitved for use on DCA.
Adds two new options next to the debugMode one to control the name of the debugging artifact uploaded and the name of the database within that artifact. This is needed on DCA because it uses the Action multiple times within one workflow with different SHAs that it is comparing, so without this the debugging artifacts will overwrite each-other. It may also be useful to users who want their debugging artifacts to have more meaningful names.
@robertbrignull This changes the code that calls codeql database bundle which is also called by the code that uploads databases to Remote Queries. In the Remote Queries instance of this case, I have passed in just language as the name of the DB. This is what was (implicitly) being used before, so I believe this change to be behaviour-preserving from the point of view of Remote Queries. You may want to check it nonetheless.
Merge / deployment checklist