Include better error message - #876
Merged
aeisenberg merged 3 commits intoJan 21, 2022
Merged
aeisenberg merged 3 commits into
aeisenberg merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
approved these changes
Jan 20, 2022
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice, seems reasonable to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'll update the changelog and then merge. Thanks for the review. |
Sorry, something went wrong.
When users call init multiple times.
Add a line item for using a better error message. Also, add a link for an entry that didn't have one before.
aeisenberg
force-pushed
the
aeisenberg/multi-init
branch
from
dfde244 to
c8290d0
Compare
January 20, 2022 18:31
aeisenberg
enabled auto-merge
January 21, 2022 16:04
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users call init multiple times. This PR addresses an error that we saw in our telemetry. It looks like there was a user who was calling the init action multiple times in the same job and getting an error. This seems like an error that new users will come across when they want to analyze databases for multiple languages.
This PR makes the error message clearer in this case.
@edoardopirovano suggested a more robust fix where we introduce a UserError and handle them differently from Errors. This PR does not implement the suggestion, but is something we can do in the future.
Merge / deployment checklist