Remove old upload path - #886
Merged
rneatherway merged 3 commits intoJan 25, 2022
Merged
rneatherway merged 3 commits into
rneatherway merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `useUploadDomain` approach is now fully enabled
Copy link
Copy Markdown
Contributor
Author
|
I still have to update the tests to match this one. |
Sorry, something went wrong.
henrymercer
reviewed
Jan 24, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think the mockHttpRequests function in database-upload.test.ts needs updating. Also we should probably delete the UploadsDomainEnabled member of the FeatureFlag enum in feature-flags.ts to indicate that new versions of the CodeQL Action no longer use that feature flag. Otherwise LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Ah, only just saw your comment :) |
Sorry, something went wrong.
robertbrignull
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The useUploadDomain approach is now fully enabled
Merge / deployment checklist