Set contentType for database uploads - #887
Merged
rneatherway merged 4 commits intoJan 25, 2022
Merged
rneatherway merged 4 commits into
rneatherway merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rneatherway
commented
Jan 24, 2022
Comment thread
src/database-upload.ts
Outdated
| data: payload, | ||
| headers: { | ||
| authorization: `token ${apiDetails.auth}`, | ||
| contentType: "application/zip", |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I'm not 100% confident about the format of this line, so I'll test it using this branch.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks right to me.
Sorry, something went wrong.
aeisenberg
approved these changes
Jan 24, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Feel free to merge if this passes all of your tests.
Sorry, something went wrong.
Comment thread
src/database-upload.ts
Outdated
| data: payload, | ||
| headers: { | ||
| authorization: `token ${apiDetails.auth}`, | ||
| contentType: "application/zip", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks right to me.
Sorry, something went wrong.
…ction into rneatherway/content-type
Copy link
Copy Markdown
Contributor
Author
|
Using the string literal as a header key worked 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist