Bump minimum supported CodeQL version to 2.4.5 to address flaky tests - #931
Merged
henrymercer merged 3 commits intoFeb 17, 2022
Merged
henrymercer merged 3 commits into
henrymercer merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is the earliest CodeQL version supported by GHES. Bumping to this version resolves some flaky tests caused by the "We still have not reached idleness" deadlock, as this deadlock is fixed in 2.4.5.
henrymercer
force-pushed
the
henrymercer/fix-flaky-tests
branch
from
8410358 to
4ef2013
Compare
February 16, 2022 12:46
Copy link
Copy Markdown
Contributor
|
Nice. Do we definitely want to do a minor version bump for this? I guess it is a breaking change, but it goes against our pattern of bumping the minor version after a GHES release. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
We've made similar deprecations for the CLI in a patch version: https://github.com/github/codeql-cli-binaries/releases/tag/v2.7.5. Given the GHES versioning constraints I'll drop the Action version bump. |
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/fix-flaky-tests
branch
from
4ef2013 to
49c1e2f
Compare
February 16, 2022 13:32
edoardopirovano
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum supported CLI version to 2.4.5. This is the earliest CodeQL version supported by the earliest supported version of GHES, i.e. GHES 3.1.
Bumping to this version resolves some flaky tests caused by the "We still have not reached idleness" deadlock, as this deadlock is fixed in 2.4.5.
Merge / deployment checklist