| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
This commit adds a `UserError` class that should be thrown when the cause of an error is fundamentally from user configuration. When sending status reports, avoid sending a `failure` for `UserError`s. This will prevent our diagnostics from pinging us for errors outside of our control.
|
OK...Looks like there may need to be a server-side change as well. Here is an attempt to send a user-error report. It fails with: user-error is not a member of ["success", "failure", "starting", "aborted"]. Alternatively, we could send aborted and avoid changing the server, but the semantics isn't right. |
Sorry, something went wrong.
There was a problem hiding this comment.
All seems good to me. You'll want to hold off merging till my PR doing the server-side changes is merged, however.
Sorry, something went wrong.
|
Server-side changes are done. I'm going to go ahead and merge this. |
Sorry, something went wrong.
|
Confirmed a test run looks good: https://github.com/edoardopirovano/actions-test2/runs/5302594964 I can also find the test run in Splunk and it's correctly tagged with user-error. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This commit adds a UserError class that should be thrown when the
cause of an error is fundamentally from user configuration.
When sending status reports, avoid sending a failure for UserErrors.
This will prevent our diagnostics from pinging us for errors outside of
our control.
This particular PR adds two cases where we use user-error instead of failure:
We can add more cases as we see fit.
Questions for reviewers:
Merge / deployment checklist