Expand PR checks to cover windows-2022 - #954
Merged
edoardopirovano merged 1 commit intoMar 1, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
marked this pull request as draft
February 28, 2022 15:34
edoardopirovano
force-pushed
the
edoardo/expand-tests
branch
from
06b7a34 to
8ec6a84
Compare
February 28, 2022 15:39
edoardopirovano
marked this pull request as ready for review
February 28, 2022 15:53
criemen
approved these changes
Feb 28, 2022
criemen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, but I don't really know about the action, so please wait for a second review before merging.
Sorry, something went wrong.
aeisenberg
approved these changes
Feb 28, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this is fine. This will add two new jobs per automated workflow. I want to be cautious about adding too many new jobs as we may start approaching limits. See the discussion here. #932
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing and reopening to restart the CI. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands our test coverage to test against windows-2022. In particular, we run these tests in addition to existing ones whenever a test is with a new CLI version and was already being run on Windows.
Merge / deployment checklist