Delete the results directory in between runs. - #955
Merged
chrisgavin merged 3 commits intoFeb 28, 2022
Merged
chrisgavin merged 3 commits into
chrisgavin merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for creating this PR. I'll take a look shortly. It is likely that this fix will also address https://github.com/github/code-scanning/issues/5318 |
Sorry, something went wrong.
aeisenberg
reviewed
Feb 28, 2022
Comment thread
src/analyze.ts
Outdated
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
chrisgavin
force-pushed
the
delete-results-directory
branch
from
02893b4 to
d63f798
Compare
February 28, 2022 18:56
chrisgavin
marked this pull request as ready for review
February 28, 2022 19:30
chrisgavin
force-pushed
the
delete-results-directory
branch
from
2df7390 to
938e0a0
Compare
February 28, 2022 19:43
aeisenberg
approved these changes
Feb 28, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍🏼
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default results directory of the CodeQL Action is in a non-ephemeral directory. This means it will be persisted between runs. The CodeQL Action also does not keep track of what languages it has produced results for in this run. That means that if a language is present in one run, but absent in the next, the CodeQL Action will upload it regardless.
By deleting the results directory we ensure that stale results will never be used.
I couldn't find a particularly good place to add a test for this (which isn't that surprising, since it's very much an implementation detail), but I've tested manually and verified it's correctly no longer uploading stale results.
Merge / deployment checklist