Add runner OS and arch to status report - #959
cklin merged 3 commits into
Conversation
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
I'm pretty sure status reports will fail to upload because of the new fields until we can make the server side changes.
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Just be sure to get the hydro schema changes deployed before merging this.
Sorry, something went wrong.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
| statusReport.matrix_vars = matrix; | ||
| } | ||
| if (runnerOs === "Windows" || runnerOs === "macOS") { | ||
| statusReport.runner_os_release = os.release(); |
There was a problem hiding this comment.
Is there a reason not to do this on linux? I just tried on one of my codespaces and I get:
Welcome to Node.js v14.17.6.
Type ".help" for more information.
> require('os').release()
'5.4.0-1069-azure'
It's not in x.y.z form, but it's still valid. I think it's the kernel version.
Sorry, something went wrong.
There was a problem hiding this comment.
There are a few reasons.
- We want to limit the cardinality of the status values reported, and there are many more variations for Linux kernel release strings than for Windows and macOS release versions.
- Linux kernel release IDs may contain custom strings, and we want to avoid recording private data (for custom kernel builds on self-hosted runners, for example).
- Windows and macOS release strings are more useful because they are representative of the entire system configuration (whether you are running Windows 10 or Windows 11, for example). Linux kernel versions are less coupled with the userspace environment—5.11.3 on RedHat could be very different from 5.11.3 on Ubuntu.
So we are recording OS releases only for Windows and macOS.
Sorry, something went wrong.
Merge / deployment checklist
This PR adds the OS and architecture (as reported by the GitHub Action Runner environments RUNNER_OS and RUNNER_ARCH) to the status report.