Status reporting: fix codeql_version field name - #992
Merged
cklin merged 1 commit intoMar 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cklin
marked this pull request as ready for review
March 23, 2022 18:35
adityasharad
approved these changes
Mar 23, 2022
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Have we got PR checks that would catch incorrect fields by failing the status reporting?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I am not sure if there is a way to do that. I think the status reporting API endpoint is specifically configured to accept unknown fields, which is generally a good thing. That does make it hard to catch field name errors—I found this one only because I was digging into the status report data and noticing that the CodeQL CLI version is always empty. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the StatusReportBase field name for CodeQL CLI version. It should be codeql_version instead of codeql_cli_version.
Merge / deployment checklist