Fix overlapping batches in refspec splitting - #147
Merged
navntoft merged 1 commit intoSep 16, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The splitLargeRefSpecs function had a logic error where it incremented by 25 but used a batch size of 100, creating overlapping batches that pushed the same refs multiple times.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
Fixes a critical logic error in the splitLargeRefSpecs function where the loop increment and batch size were mismatched, causing overlapping batches and duplicate ref pushes.
- Introduces a batchSize variable set to 25 to ensure consistency
- Updates loop increment to use the batchSize variable instead of hardcoded 25
- Changes batch end calculation to use batchSize instead of hardcoded 100
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
oscarsj
approved these changes
Sep 16, 2025
oscarsj
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The splitLargeRefSpecs function had a logic error where it incremented by 25 but used a batch size of 100, creating overlapping batches that pushed the same refs multiple times.
Could potentially solve an issue with pushing refs to GHES instances.