Fix tags not being resolved before use. - #68
Merged
chrisgavin merged 1 commit intoApr 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
simon-engledew
approved these changes
Apr 28, 2022
simon-engledew
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I ran go run . pull locally and it correctly resolved the v1/v2 tags:
DEBU[0032] Found refs/heads/main. DEBU[0032] Resolved to 6ed7f7079817cf4b3d0248d1cfb3aa83781ddd0a. DEBU[0032] Found refs/tags/v1. DEBU[0032] Resolved to 6c3ae45f3a4a4cfd22f4876f5c2d393d491b51e8. DEBU[0032] Found refs/tags/v2.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes tags not being dereferenced before being used, which has started causing the tool to fail since github/codeql-action was updated to use tags to reference each release rather than branches.