Add some release asset upload retrying. - #74
Merged
chrisgavin merged 2 commits intoJun 14, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chrisgavin
force-pushed
the
upload-retrying
branch
11 times, most recently
from
127bc30 to
38c5894
Compare
May 31, 2022 10:06
chrisgavin
force-pushed
the
upload-retrying
branch
from
38c5894 to
4d9b39a
Compare
June 14, 2022 13:37
chrisgavin
force-pushed
the
upload-retrying
branch
from
4d9b39a to
d089cfe
Compare
June 14, 2022 13:38
chrisgavin
marked this pull request as ready for review
June 14, 2022 13:46
Comment thread
internal/push/push.go
Outdated
| if err != nil { | ||
| return errors.Wrap(err, "Error opening release asset.") | ||
| } | ||
| defer assetFile.Close() |
Copy link
Copy Markdown
There was a problem hiding this comment.
I think defering inside a for loop might cause a resource leak here? If so, you might have to move this block into a function.
Sorry, something went wrong.
simon-engledew
approved these changes
Jun 14, 2022
simon-engledew
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks good, although I've not tested it out. 🙏
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully improves the success rate of uploading to the integration test instance.
We retry on 5xx errors, and handle already_exists errors explicitly. The reason for handling `already_exists is that it seems like sometimes the "failed upload" from a 5xx error will actually finish successfully in the background so if we retry again we'll get a 422 due to uploading a duplicate asset.