refactor: Migrate to Vite - #11
Merged
ThisIsKirsch merged 2 commits intoOct 23, 2023
Merged
ThisIsKirsch merged 2 commits into
ThisIsKirsch merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AbdullahWins
reviewed
Oct 3, 2023
AbdullahWins
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Good Job!
Sorry, something went wrong.
ThisIsKirsch
self-requested a review
October 23, 2023 15:30
Copy link
Copy Markdown
Contributor
|
Hey @rschristian , we’re going to accept this PR, and we apologize for removing the content meant to help the end user. Thanks for making this PR! |
Sorry, something went wrong.
ThisIsKirsch
approved these changes
Oct 23, 2023
Copy link
Copy Markdown
Contributor
Author
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (the Preact team) no longer recommend using preact-cli; it's unfortunately not been able to get the development time it deserves and other tools offer a much better experience. We recommend Vite, and this updated template comes from our initializer create-preact.
I will say that I was quite disappointed to see someone took the time to copy my project template but (poorly) stripped out all of our reference material and slapped an Octocat in its place. That'd be fine if it were a custom-built template, but please don't strip out my work that's meant to help the end user and put your own branding in its place. It feels quite disrespectful.