Repository navigation
Handle fork PR associations in invalid-label writer - #4497
Merged
devm33 merged 1 commit intoAug 29, 2026
Merged
devm33 merged 1 commit into
devm33 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 512eb347-ec89-4250-8bf1-87048974b01d
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds fail-closed fork PR discovery when workflow-run PR associations are absent.
Changes:
- Validates workflow-run head metadata.
- Finds one exact open PR by repository, branch, and SHA.
- Revalidates the resolved PR before closing it.
| File | Description |
|---|---|
| .github/workflows/close-invalid-pr-writer.yml | Adds secure fallback PR association and validation. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Sorry, something went wrong.
This was referenced Aug 15, 2026
devm33
approved these changes
Aug 29, 2026
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the trusted invalid-label writer to handle fork pull request workflow runs when GitHub does not populate the run's pull request association.
When the association is absent, the writer now searches using trusted workflow-run metadata and requires exactly one open pull request matching the expected base repository, full head repository, branch, and head SHA. Ambiguous, malformed, or stale matches continue to fail closed.
The existing workflow identity checks, pull request revalidation, label/state checks, write permissions, and scheduled reconciliation fallback remain unchanged.
Validation