FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix inconsistent req/res in issues.md by lidice · Pull Request #1002 · github/developer.github.com · GitHub

This repository was archived by the owner on Nov 1, 2017. It is now read-only.
/ developer.github.com Public archive

Fix inconsistent req/res in issues.md - #1002

Merged
tarebyte merged 1 commit into
github:masterfrom
lidice:patch-1
Mar 15, 2016
ConversationCommits (1)ChecksFindingsFiles changed
Merged

Fix inconsistent req/res in issues.md#1002
tarebyte merged 1 commit into
github:masterfrom
lidice:patch-1

Conversation

lidice commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

Found inconsistent mistakes to request and response examples -

part of request (in Create an issue & Edit an issue)

  "labels": [
    "Label1",
    "Label2"
  ]

part of response (inCreate an issue & Edit an issue)

"labels": [
  {
    "url": "https://api.github.com/repos/octocat/Hello-World/labels/bug",
    "name": "bug",
    "color": "f29513"
  }
],

I changed request examples.

Fix inconsistent req/res in issues.md
730eec1 
Found inconsistent mistakes to request and response examples.

Shredder121 commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

IIRC, I the request was simple, just the label name.
But we'll wait for some official response.

lidice commented Feb 10, 2016

Copy link
Copy Markdown
Contributor Author

@Shredder121

I apologize for any confusion.

As you say, the request of labels requires name only.
What I'm saying is that the request and the response doesn't match in examples.
To be more specific, following that.

Request: label1,label2
Response: bug

I think that's odd.

Thanks.

Shredder121 commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

Whoops, yes I see what you mean now.
Probably wasn't well awake.

That's indeed odd.

tarebyte commented Mar 15, 2016

Copy link
Copy Markdown
Member

This looks great @lidice sorry for the delay in getting back to you.

tarebyte added a commit that referenced this pull request Mar 15, 2016
Merge pull request #1002 from lidice/patch-1
af3f361 
Fix inconsistent req/res in issues.md
tarebyte merged commit af3f361 into github:master Mar 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL