Add optional string array param - #101
Merged
williammartin merged 1 commit intoApr 4, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an optional string array parameter handling to fix an integration bug where parameters provided as []any were not properly coerced to []string.
- Introduces a new helper function optionalStringArrayParam in pkg/github/server.go.
- Adds new tests in pkg/github/server_test.go to validate the behavior of string array parameter handling.
- Updates issues related functions and tests in pkg/github/issues.go and pkg/github/issues_test.go to utilize the new helper.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/server_test.go | New test cases for validating optional string array parameter handling. |
| pkg/github/server.go | New helper function optionalStringArrayParam with improved type checking and error messages. |
| pkg/github/issues_test.go | Updated test cases to provide []any for assignees and labels. |
| pkg/github/issues.go | Replaced use of generic optionalParam with optionalStringArrayParam for parameters conversion. |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
Comment thread
pkg/github/server_test.go
Outdated
williammartin
force-pushed
the
wm/optional-string-array-param
branch
from
baf5038 to
255ba08
Compare
April 4, 2025 15:26
SamMorrowDrums
approved these changes
Apr 4, 2025
juruen
approved these changes
Apr 4, 2025
toby
approved these changes
Apr 4, 2025
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an integration bug introduced in #82, where the MCP host was providing a slice that was treated as []any and not coerced to []string.