问我 - #1107
Closed
Rroqheo wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional content handling to the handleFailedJobLogs function, implementing a new code path that returns structured resource content when the returnContent flag is true. The change allows the function to provide job logs as embedded resources with JSON MIME type instead of plain text.
- Added conditional logic to return structured content with embedded resources
- Implemented JSON marshaling and resource creation for failed job logs
- Created URIs for individual job log resources
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
jojkoloski
approved these changes
Sep 21, 2025
jojkoloski
approved these changes
Sep 21, 2025
Copy link
Copy Markdown
|
- Copilot suggests changes to a pull request for conditional content
handling.
- Josué Alejandro Marquez Oropeza approved the pull request.
***@***.***
…On Mon, 22 Sept 2025, 12:09 am Josué Alejandro Marquez Oropeza, < ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1107 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3H3VBOAB4W7NPSZF7XVDX33T2WRFAVCNFSM6AAAAACHCK4NACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJQGAZTSMRQGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sorry, something went wrong.
Rroqheo
commented
Sep 29, 2025
Rroqheo
left a comment
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
1
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: