| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Clean PR — extends the existing tool correctly, uses the right GraphQL mutations, and tests cover the key cases. Ready for merge with minor notes:
Nice work filling a real gap in the PR review workflow. |
Sorry, something went wrong.
Adds `resolve_thread` and `unresolve_thread` methods to the `pull_request_review_write` tool, enabling users to resolve and unresolve PR review threads via GraphQL mutations. - Add ThreadID field to PullRequestReviewWriteParams struct - Add threadId parameter and new methods to tool schema - Implement ResolveReviewThread function using GraphQL mutations - Add switch cases for resolve_thread and unresolve_thread methods - Add unit tests covering success, error, empty and omitted threadId - Document that owner/repo/pullNumber are unused for these methods - Document idempotency (resolving already-resolved is a no-op) - Update toolsnaps and generated docs Fixes github#1768 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
I believe the feedback should be addressed. I'm not a frequent contributor to this repo so if there is anything I need to amend just let me know! I squashed the commits as well |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
|
Would love to get this feature in - currently when claude et al. are using the github MCP server they can create threads with suggestions but if the suggestion is approved / fixed they can't resolve the thread. It may seem like a small quality of life thing but it's nice when we can get the thread resolved. |
Sorry, something went wrong.
|
We could really use this as well! |
Sorry, something went wrong.
|
Everything is updated, is there anyone who can help with merging or letting me know what to update? |
Sorry, something went wrong.
|
Hey @plwalters, I also need this feature and wanted to help move it forward with a review. ReviewClean PR — extends the existing pull_request_review_write tool correctly with resolve_thread and unresolve_thread methods. Uses the right GraphQL mutations, includes good input validation, and tests cover success, empty/omitted input, and error scenarios. Nice work. Missing thread ID in get_review_comments outputThis is the main gap. The tool description says "Get thread IDs from pull_request_read with method get_review_comments", but MinimalReviewThread does not include an ID field: type MinimalReviewThread struct {
IsResolved bool `json:"is_resolved"`
IsOutdated bool `json:"is_outdated"`
IsCollapsed bool `json:"is_collapsed"`
Comments []MinimalReviewComment `json:"comments"`
TotalCount int `json:"total_count"`
}The underlying reviewThreadNode GraphQL type already has ID githubv4.ID, but convertToMinimalReviewThread doesn't expose it. Without this, callers have no way to discover the threadId needed for resolve/unresolve through the MCP server itself. Fix would be:
owner/repo/pullNumber required but unused (minor)The schema has Required: []string{"method", "owner", "repo", "pullNumber"}, but resolve_thread/unresolve_thread only use params.ThreadID. The description documents this clearly, so it's just a minor UX friction — callers must provide dummy values for unused fields. Not a blocker, just a trade-off of the multi-method tool pattern. Everything else looks good
Generated-by: Claude Code |
Sorry, something went wrong.
|
Thank you for the contribution! |
Sorry, something went wrong.
|
Thanks for approving it! Our team will appreciate this one for sure |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Adds resolve_thread and unresolve_thread methods to the pull_request_review_write tool, enabling users to resolve and unresolve PR review threads via GraphQL mutations.
Why
Fixes #1768
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
Docs