FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update title annotations for `issue_write` and `add_issue_comment` tools to reflect that they also work with pull requesta by timrogers · Pull Request #2664 · github/github-mcp-server · GitHub

/ github-mcp-server Public

Update title annotations for issue_write and add_issue_comment tools to reflect that they also work with pull requesta - #2664

Merged
SamMorrowDrums merged 4 commits into
github:mainfrom
timrogers:timrogers/issue-pr-tool-mapping
Jun 10, 2026
ConversationCommits (4)ChecksFindingsFiles changed
Merged

Update title annotations for issue_write and add_issue_comment tools to reflect that they also work with pull requesta#2664
SamMorrowDrums merged 4 commits into
github:mainfrom
timrogers:timrogers/issue-pr-tool-mapping

Conversation

timrogers commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This updates our tool title annotations for tools that can operate on issues AND pull requests to clarify that they work with issues and pull requests: issue_write and add_issue_comment.

The current titles only mention issues, which can be confusing in MCP clients when the tools are being used.

Why

When these tools appear in client UIs, issue-only wording is confusing and can mislead users/agents into thinking PR operations are unsupported.

What changed

  • Updated add_issue_comment annotation title to Add comment to issue or pull request.
  • Updated issue_write annotation title to Create or update issue/pull request.
  • Regenerated tool snapshots and docs to reflect the metadata changes.

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

This change updates tool metadata (annotations.title) exposed to MCP clients so tool labeling in UI better matches actual capability. Runtime behavior is unchanged.

Prompts tested (tool changes only)

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
    • I have added the new tool aliases in deprecated_tool_aliases.go
  • I am not renaming tools as part of this PR

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)

Clarify issue tool titles for PR context
f456a5f 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
timrogers requested a review from a team as a code owner June 10, 2026 15:37
Copilot AI review requested due to automatic review settings June 10, 2026 15:37
Copilot AI reviewed Jun 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Updates MCP tool annotation titles so MCP client UIs better reflect that some “issue” tools also apply to pull requests (since PRs are issues in GitHub’s API), and propagates those metadata changes into generated docs/snapshots.

Changes:

  • Update add_issue_comment tool annotation title to “Add comment to issue or pull request”.
  • Update issue_write tool annotation title to mention pull requests.
  • Regenerate README tool docs and toolsnap snapshots to reflect updated annotations.
Show a summary per file
File Description
README.md Updates generated tool listing strings for the new annotation titles.
pkg/github/issues.go Changes annotations.title for add_issue_comment and issue_write.
pkg/github/toolsnaps/add_issue_comment.snap Updates snapshot to reflect add_issue_comment title change.
pkg/github/toolsnaps/issue_write.snap Updates snapshot to reflect issue_write title change.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 1

Comment thread pkg/github/issues.go
Description: t("TOOL_ISSUE_WRITE_DESCRIPTION", "Create a new or update an existing issue in a GitHub repository."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_ISSUE_WRITE_USER_TITLE", "Create or update issue."),
Title: t("TOOL_ISSUE_WRITE_USER_TITLE", "Create or update issue/pull request"),

timrogers Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is true - but it seems like it would be too confusing to add this context to the title.

Merge remote-tracking branch 'upstream/main' into timrogers/issue-pr-…
7009502 
…tool-mapping

# Conflicts:
#	README.md
#	pkg/github/__toolsnaps__/issue_write.snap
#	pkg/github/issues.go
timrogers commented Jun 10, 2026
View reviewed changes
Comment thread pkg/github/issues.go
timrogers and others added 2 commits June 10, 2026 18:11
Fix issue_write_ff_remote_mcp_issue_fields snap title
e151602 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Re-generate docs after upstream merge
e4cabb1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
timrogers requested a review from SamMorrowDrums June 10, 2026 17:42
SamMorrowDrums merged commit 8bbd902 into github:main Jun 10, 2026
13 checks passed

SamMorrowDrums commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

I don't love the leaky abstraction, but this is technically accurate and users are fine to know this. Models should not be getting these fields.

BrewTestBot mentioned this pull request Jun 11, 2026
Merged
github-actions Bot mentioned this pull request Jun 12, 2026
Closed
morganwwallen29-lang reviewed Jun 25, 2026
View reviewed changes

morganwwallen29-lang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Security ip

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
SamMorrowDrums SamMorrowDrums approved these changes
+1 more reviewer
morganwwallen29-lang morganwwallen29-lang left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL