fix(repos): default create_repository to private when visibility omitted - #2694
Merged
JoannaaKL merged 1 commit intoJun 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Previously, omitting the `private` parameter on create_repository defaulted the new repository to public, an insecure default that could unintentionally expose code, configuration, and history. Omission now defaults to a private repository; public repositories are only created when `private` is explicitly set to false. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
Author
|
This addresses the insecure default where create_repository produced a public repo when private was omitted. Decision summary:
Verified with script/lint (0 issues), go test -race ./... (passing), and script/generate-docs. Tool snapshot and README updated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the create_repository MCP tool to default to creating private repositories when the optional private parameter is omitted, reducing the risk of unintentionally creating public repos in agent-driven workflows.
Changes:
- Default private to true at runtime via OptionalBoolParamWithDefault(args, "private", true).
- Make the default explicit in the tool schema (default: true) and parameter description.
- Update tests, toolsnapshot, and README documentation to reflect the new default behavior.
| File | Description |
|---|---|
| README.md | Updates create_repository.private docs to state it defaults to private when omitted. |
| pkg/github/repositories.go | Sets schema default for private and changes runtime parsing to default omitted private to true. |
| pkg/github/repositories_test.go | Updates minimal-args test to expect private repo by default and adds an explicit private: false public repo test. |
| pkg/github/toolsnaps/create_repository.snap | Updates snapshot to include default: true and the updated description for private. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
Sorry, something went wrong.
JoannaaKL
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_repository previously created a public repository whenever the private parameter was omitted. Because the parameter is optional, agent-driven or automated workflows could unintentionally create public repos, exposing source code, configuration, workflow files, and commit history.
This change makes the secure choice the default: omitting private now creates a private repository. A public repository is only created when private is explicitly set to false.
Changes
Behavior
Verification