Bump Go toolchain to 1.26.4 - #2705
Closed
SamMorrowDrums wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Move the project from the Go 1.25 line to the latest stable Go 1.26.4. - go.mod: go directive 1.25.0 -> 1.26.0 (language floor; no toolchain directive introduced by `go mod tidy`) - Dockerfile: golang:1.25.11-alpine -> golang:1.26.4-alpine, repinned to the current index digest - .github/workflows/lint.yml: go-version 1.25 -> 1.26 (other workflows use go-version-file: go.mod and follow automatically) - .github/copilot-instructions.md: update Dockerfile reference - .golangci.yml: disable only the modernize `newexpr` analyzer; the Go 1.26 new(expr) feature otherwise flags ~1.2k github.Ptr() call sites, which is out of scope for a toolchain bump Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repository’s Go version baseline and tooling configuration to move from the Go 1.25 line to Go 1.26, and updates build/CI pins accordingly.
Changes:
- Bump go.mod language version to Go 1.26.0.
- Update the Docker build stage to golang:1.26.4-alpine (digest pinned) and adjust CI lint workflow’s Go setup.
- Configure golangci-lint to disable only modernize’s newexpr analyzer to avoid a large out-of-scope rewrite.
| File | Description |
|---|---|
| go.mod | Raises the module’s Go language version floor to 1.26.0. |
| Dockerfile | Updates the builder image to Go 1.26.4 (digest pinned). |
| .golangci.yml | Disables only modernize’s newexpr analyzer while keeping modernize enabled. |
| .github/workflows/lint.yml | Updates the lint workflow’s Go version selection for Go 1.26. |
| .github/copilot-instructions.md | Updates contributor guidance to reference the new Docker Go version. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
Sorry, something went wrong.
Comment thread
go.mod
Comment on lines
1
to
4
| module github.com/github/github-mcp-server | ||
|
|
||
| go 1.25.0 | ||
| go 1.26.0 | ||
|
|
Comment thread
.github/workflows/lint.yml
Comment on lines
19
to
22
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.25' | ||
| go-version: '1.26' | ||
| - name: golangci-lint |
Comment thread
.github/copilot-instructions.md
Comment on lines
95
to
+97
| - **go.mod / go.sum:** Go module dependencies (Go 1.24.0+) | ||
| - **.golangci.yml:** Linter configuration (v2 format, ~15 linters enabled) | ||
| - **Dockerfile:** Multi-stage build (golang:1.25.8-alpine → distroless) | ||
| - **Dockerfile:** Multi-stage build (golang:1.26.4-alpine → distroless) |
javi0guerrero4-cloud
approved these changes
Jun 16, 2026
javi0guerrero4-cloud
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Merge
Sorry, something went wrong.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the project from the Go 1.25 line to the latest stable Go 1.26.4. This is a deliberate minor-version bump, so it gets its own PR with full CI rather than an admin/digest-only update.
Pins changed
Notes:
New Go 1.26 lint finding — and why it's scoped out
Bumping go.mod to 1.26 enables the modernize newexpr modernizer (the new new(expr) builtin). golangci-lint's max-same-issues: 3 made it look like only 11 findings, but it actually flags ~1,176 github.Ptr(...) → new(...) rewrites across 33 files. That's a sweeping, unrelated refactor — out of scope for a toolchain bump.
Rather than churn the whole codebase or blanket-disable a linter, I disabled only the newexpr analyzer in .golangci.yml (all other modernize checks stay active). Adopting new(expr) can be done later as a separate, focused change. Flagging for maintainer review in case you'd prefer the wholesale adoption instead.
No other new go vet / staticcheck / golangci-lint findings appeared.
Validation
Please let full CI validate — do not force-merge.