Enrich issue_read get with hierarchy relationship signals by zwick · Pull Request #2764 · github/github-mcp-server · GitHub

Summary

Enrich the issue_read get payload with layered hierarchy relationship signals, derived from a single combined GraphQL round-trip (no added round-trips on get).

Why

The default get payload surfaced no relationship data, so an agent calling the most obvious tool got zero hierarchy signal and had to drop to raw REST (parent_issue_url) or scan sibling sub-issues. This also addresses the #2726 review note asking for cheap has_parent / has_children routing booleans as a follow-up.

Refs github/planning-tracking#3306

What changed

issue_read get now returns has_parent / has_children (always emitted), plus parent and sub_issues_summary when those relationships exist.
Replaced the single-issue field-values GraphQL call with one combined query (fetchIssueReadEnrichment) returning field values + parent + subIssuesSummary.
Best-effort enrichment: a query failure still returns the base issue and never fails get.
Parent title is sanitized (may be cross-repo) and redacted under lockdown mode unless the parent content is verified safe; counts/booleans are always emitted.
get_parent / sub_issue_write behavior unchanged; tool descriptions now clarify optional hierarchy summaries and write routing via sub_issue_write.

MCP impact

Tool schema or behavior changed — issue_read get response gains hierarchy fields; issue_read and sub_issue_write method descriptions updated.

Prompts tested (tool changes only)

"Read issue Hello maintainers, #2990 in github/github-mcp-server" — expect has_parent: true and parent (Verificado por Edgarruiz8585 gh pr checkout 45045 #2820) without raw REST / sibling scanning. Covered by unit tests; live MCP verification noted as a manual follow-up.

Security / limits

Data exposure, filtering, or token/size limits considered — parent titles are sanitized and redacted under lockdown mode when the (possibly cross-repo) parent content cannot be verified as safe; numeric/structural fields stay intact.

Tool renaming

I am not renaming tools as part of this PR

Lint & tests

Linted locally with ./script/lint
Tested locally with ./script/test

Docs

Updated (README / docs / examples)

Pull request overview

This PR enriches the issue_read tool’s get response with lightweight issue hierarchy signals (parent/children presence) and optional relationship summaries, sourced from a single combined GraphQL query and designed to be best-effort (never failing get).

Changes:

Added hierarchy relationship fields (has_parent, has_children, optional parent, optional sub_issues_summary) to the minimal issue payload returned by issue_read get.
Replaced the prior field-values-only GraphQL enrichment with a combined enrichment query (fetchIssueReadEnrichment) and applied it via applyIssueReadEnrichment, including lockdown-aware parent redaction.
Updated tool/README descriptions and added unit tests covering hierarchy enrichment and failure behavior.

Show a summary per file

File	Description
README.md	Updates generated docs to clarify issue_read get hierarchy signals and sub_issue_write routing guidance.
pkg/github/minimal_types.go	Extends MinimalIssue with hierarchy fields and adds helper types for parent reference and sub-issue summary.
pkg/github/issues.go	Implements combined GraphQL enrichment for issue_read get and lockdown-safe parent surfacing.
pkg/github/issues_test.go	Adds tests for hierarchy enrichment, lockdown redaction behavior, and best-effort fallback on query failure.
pkg/github/toolsnaps/sub_issue_write.snap	Updates schema snapshot for revised sub_issue_write method description.
pkg/github/toolsnaps/issue_read.snap	Updates schema snapshot for revised issue_read method description.

Review details

Files reviewed: 6/6 changed files
Comments generated: 3
Review effort level: Low

The default issue_read `get` payload surfaced no hierarchy data, forcing agents to drop to raw REST (parent_issue_url) or scan sibling sub_issues to discover relationships. Enrich `get` with a layered, zero-extra-round-trip relationship signal derived from a single combined GraphQL query: - has_parent / has_children: cheap, always-emitted routing booleans (addresses Sam Morrow's #2726 review note). - parent: compact ref (number/title/state/url/repository) mirroring the existing get_parent payload keys; omitted when there is no parent. - sub_issues_summary: native subIssuesSummary counts (total/completed/ percent_completed); omitted when there are no sub-issues. The single-issue field-values GraphQL call in GetIssue is replaced by one combined query (fetchIssueReadEnrichment) returning field values + parent + subIssuesSummary, so `get` adds no round-trips. Enrichment is best-effort: a query failure still returns the base issue and never fails `get`. Parent titles are sanitized (parent may be cross-repo) and redacted under lockdown mode unless the parent content can be verified as safe; numeric/structural fields and counts stay intact. get_parent / sub_issue_write behavior is unchanged; tool descriptions clarify hierarchy is read here but written via sub_issue_write (no writable parent field). Refs github/planning-tracking#3306 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Align issue_read get parent enrichment with the codebase's existing lockdown patterns: rather than introducing a third, redaction-with-sentinel behavior, omit the whole parent reference when its (possibly cross-repo) content cannot be verified safe. This mirrors how unsafe comments, sub-issues, and PR reviews are filtered out. has_parent stays true so an agent can still route to get_parent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Passed

Upload and merge create a new branch if you have to

zwick self-assigned this Jun 25, 2026

zwick force-pushed the zwick-enrich-issue-read-hierarchy branch 3 times, most recently from d7f0c8c to a8ed349 Compare June 26, 2026 14:25

zwick mentioned this pull request Jun 26, 2026

Sanitize and lockdown-gate issue_read get_parent title #2780

Merged

6 tasks

zwick marked this pull request as ready for review June 26, 2026 15:59

zwick requested a review from a team as a code owner June 26, 2026 15:59

Copilot AI review requested due to automatic review settings June 26, 2026 15:59

Copilot started reviewing on behalf of zwick June 26, 2026 16:00 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread pkg/github/minimal_types.go Outdated

Comment thread pkg/github/minimal_types.go

Comment thread pkg/github/issues_test.go Outdated

zwick and others added 4 commits June 30, 2026 10:02

Tighten hierarchy tool wording

85709bf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Restore explicit issue read query matcher

4d78776

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

zwick force-pushed the zwick-enrich-issue-read-hierarchy branch from d0a3b66 to 4d78776 Compare June 30, 2026 14:02

zwick and others added 2 commits June 30, 2026 10:10

Omit hierarchy flags when enrichment fails

71b3b4f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Address hierarchy review nits

cd3e9ac

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Trustinbtc999-hue approved these changes Jul 6, 2026

View reviewed changes

Trustinbtc999-hue reviewed Jul 7, 2026

View reviewed changes

kerobbi approved these changes Jul 7, 2026

View reviewed changes

Merge branch 'main' into zwick-enrich-issue-read-hierarchy

215e10a

kerobbi merged commit b7bc3dc into main Jul 7, 2026
19 checks passed

kerobbi deleted the zwick-enrich-issue-read-hierarchy branch July 7, 2026 11:18

BrewTestBot mentioned this pull request Jul 15, 2026

github-mcp-server 1.6.0 Homebrew/homebrew-core#293356

Merged

Enrich issue_read get with hierarchy relationship signals by zwick · Pull Request #2764 · github/github-mcp-server · GitHub

Uh oh!

Enrich issue_read get with hierarchy relationship signals - #2764

Enrich issue_read get with hierarchy relationship signals#2764
kerobbi merged 7 commits into
mainfrom
zwick-enrich-issue-read-hierarchy

zwick commented Jun 24, 2026 •
edited
Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Trustinbtc999-hue left a comment

Uh oh!

Trustinbtc999-hue left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Enrich issue_read get with hierarchy relationship signals by zwick · Pull Request #2764 · github/github-mcp-server · GitHub

Uh oh!

Enrich issue_read get with hierarchy relationship signals - #2764

Enrich issue_read get with hierarchy relationship signals#2764kerobbi merged 7 commits intomaingithub/github-mcp-server:mainfrom zwick-enrich-issue-read-hierarchygithub/github-mcp-server:zwick-enrich-issue-read-hierarchyCopy head branch name to clipboard

Conversation

zwick commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

What changed

MCP impact

Prompts tested (tool changes only)

Security / limits

Tool renaming

Lint & tests

Docs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Trustinbtc999-hue left a comment

Choose a reason for hiding this comment

Uh oh!

Trustinbtc999-hue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Enrich issue_read get with hierarchy relationship signals#2764
kerobbi merged 7 commits into
mainfrom
zwick-enrich-issue-read-hierarchy

zwick commented Jun 24, 2026 •
edited
Loading