perf(octicons): embed precomputed data URIs - #2895
Merged
SamMorrowDrums merged 1 commit intoJul 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Move Octicon base64 encoding to the generation script and embed the generated lookup manifest for zero-allocation reads. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5557f448-5cc1-46ce-b5ad-36f9e2e224e0
15 tasks
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Precomputes Octicon data URIs during icon generation, replacing runtime encoding with fast map lookups.
Changes:
- Generates and embeds a data URI manifest.
- Validates manifest entries against PNG assets.
- Adds lookup and registration benchmarks.
| File | Description |
|---|---|
| script/fetch-icons | Generates the data URI manifest. |
| pkg/octicons/octicons.go | Loads manifest and provides map-based lookup. |
| pkg/octicons/octicons_test.go | Verifies URI correctness and coverage. |
| pkg/octicons/octicons_benchmark_test.go | Benchmarks lookup and icon creation. |
| pkg/octicons/icons_data_uris.txt | Stores generated PNG data URIs. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
Sorry, something went wrong.
Comment thread
script/fetch-icons
| # Generates both light theme (dark icons) and dark theme (white icons) variants. | ||
| # Uses sed to modify SVG fill color before converting to PNG. | ||
| # Requires: rsvg-convert (from librsvg2-bin on Ubuntu/Debian) | ||
| # Requires: rsvg-convert (from librsvg2-bin on Ubuntu/Debian), base64 |
SamMorrowDrums
deleted the
sammorrowdrums-embed-precomputed-octicon-data-uris
branch
July 16, 2026 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #2851. Thanks @dexhunter for identifying the repeated encoding overhead and proposing the caching improvement; this moves that work to generation time instead.
The original uncached/cold lookup was about 4162 ns/op, 8874 B/op, 13 allocs/op. The generated lookup is about 26 ns/op, 0 B/op, 0 allocs/op. This trades roughly 48 KB of embedded data for eliminating runtime base64 work and synchronization.
The remote server's wrapper can continue checking remote-specific icons first and falling back to this OSS package, preserving its existing extension model.
Fixes #2850