FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle unsupported issueFieldValues enrichment in search_issues by kerobbi · Pull Request #2897 · github/github-mcp-server · GitHub

/ github-mcp-server Public

Handle unsupported issueFieldValues enrichment in search_issues - #2897

Merged
SamMorrowDrums merged 2 commits into
mainfrom
kerobbi/fix-search-issues-ghes-field-values
Aug 19, 2026
ConversationCommits (2)ChecksFindingsFiles changed
Merged

Handle unsupported issueFieldValues enrichment in search_issues#2897
SamMorrowDrums merged 2 commits into
mainfrom
kerobbi/fix-search-issues-ghes-field-values

Conversation

kerobbi commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes the custom field value enrichment in search_issues best-effort, so a search no longer fails when the server's GraphQL schema doesn't support the issueFieldValues field (e.g. GHES).

Why

Fixes #2831

What changed

  • Made the follow-up GraphQL field value enrichment best-effort: a failure getting the GraphQL client or running the enrichment query is now recorded on the request context instead of failing the search
  • search_issues returns its REST hits (with field_values omitted) when enrichment is unavailable, matching how issue_read get already treats the same enrichment
  • Added Test_SearchIssues_FieldValuesEnrichmentUnsupported covering the unsupported-schema path

MCP impact

  • Tool schema or behavior changed - search_issues now degrades gracefully instead of failing when field value enrichment is unsupported

Security / limits

  • No security or limits impact

Tool renaming

  • I am not renaming tools as part of this PR

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed

Copilot AI review requested due to automatic review settings July 16, 2026 14:55
kerobbi requested a review from a team as a code owner July 16, 2026 14:55
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR updates the search_issues tool’s custom-field enrichment to be best-effort so it no longer fails on GitHub Enterprise Server instances whose GraphQL schema does not support issueFieldValues (e.g., GHES 3.20.x). The search now returns REST results even when GraphQL enrichment is unavailable, aligning with the existing “best-effort enrichment” behavior in issue_read get.

Changes:

  • Made search_issues GraphQL-based field_values enrichment non-fatal and record enrichment failures on the request context.
  • Ensured search_issues returns REST hits with field_values omitted when enrichment cannot be performed.
  • Added a unit test covering the unsupported-schema (issueFieldValues missing) path.
Show a summary per file
File Description
pkg/github/issues.go Makes search_issues field-value enrichment best-effort (do not fail the search when enrichment fails).
pkg/github/issues_test.go Adds coverage for the unsupported GraphQL schema scenario to ensure REST results still return.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Low

rkjakeer commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Hi @kerobbi,

This fixes search_issues, but list_issues has the same class of GHES incompatibility via a different code path and still fails (confirmed against v1.8.0):

failed to list issues: IssueFieldValueFilter isn't a defined input type (on $issueFieldValues)

Here issueFieldValues is used as a query variable / input type (IssueFieldValueFilter) rather than a response field, so the graceful-degradation change here doesn't cover it. Can the same best-effort treatment be applied to list_issues, or should a follow-up PR be opened?

kerobbi force-pushed the kerobbi/fix-search-issues-ghes-field-values branch from f969d44 to 23b9eeb Compare August 14, 2026 10:30
kerobbi mentioned this pull request Aug 14, 2026
Closed

kerobbi commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Hey @rkjakeer - your analysis is spot on, thanks for writing it up and apologies for having taken a while to get back to you! A follow-up PR is the right call here, I've opened #3068 to track it 🙂

kerobbi and others added 2 commits August 19, 2026 12:28
make search_issues field value enrichment best-effort
f041695
fix(issues): narrow search field enrichment fallback
b9a7ebf 
Only tolerate GraphQL schema validation failures that show the optional Issue.issueFieldValues selection or its known fragments are unsupported. Surface client, auth, rate-limit, network, resolver, malformed response, and unrelated GraphQL failures.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SamMorrowDrums force-pushed the kerobbi/fix-search-issues-ghes-field-values branch from fb49a7d to b9a7ebf Compare August 19, 2026 10:31
SamMorrowDrums merged commit c64b6fe into main Aug 19, 2026
19 checks passed
SamMorrowDrums deleted the kerobbi/fix-search-issues-ghes-field-values branch August 19, 2026 11:09
github-actions Bot mentioned this pull request Aug 20, 2026
Closed
Copilot AI mentioned this pull request Aug 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
SamMorrowDrums SamMorrowDrums approved these changes
+1 more reviewer
9qrv90-a11y 9qrv90-a11y approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Field 'issueFieldValues' doesn't exist on type 'Issue'

5 participants

Back | FazBrowse Home | New Git URL