fix(actions): avoid malformed response on log download failure - #3066
Merged
SamMorrowDrums merged 1 commit intoAug 14, 2026
Merged
fix(actions): avoid malformed response on log download failure#3066SamMorrowDrums merged 1 commit into
SamMorrowDrums merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9cdeefb9-91cd-4f65-8eb2-089c9e00a2b8
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents malformed GitHub responses when workflow log downloads fail before receiving an HTTP response.
Changes:
- Returns nil when no HTTP response exists.
- Preserves available HTTP response metadata.
- Adds transport-failure regression coverage.
| File | Description |
|---|---|
| pkg/github/actions.go | Conditionally wraps available HTTP responses. |
| pkg/github/actions_test.go | Verifies transport failures return a nil response. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Sorry, something went wrong.
kerobbi
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents consumers such as github-mcp-server-remote from receiving a non-nil *github.Response whose embedded *http.Response is nil. Companion defensive fix: github/github-mcp-server-remote#926.