Expose Copilot review thread resolution reasons - #3123
Open
cagesellchen wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bf69b12-5131-4382-8c81-8ed1c88fb211
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes optional Copilot review-thread resolution reasons through both resolution tools and forwards them to GraphQL.
Changes:
- Added resolutionReason to both tool schemas.
- Forwarded optional reasons through the shared resolver.
- Updated tests, snapshots, and generated documentation.
| File | Description |
|---|---|
| README.md | Documents the aggregate tool parameter. |
| pkg/github/pullrequests.go | Adds reason forwarding to the shared resolver. |
| pkg/github/pullrequests_test.go | Tests aggregate reason forwarding. |
| pkg/github/pullrequests_granular.go | Adds the granular tool parameter. |
| pkg/github/granular_tools_test.go | Tests granular reason forwarding. |
| pkg/github/__toolsnaps__/resolve_review_thread.snap | Updates the granular tool schema snapshot. |
| pkg/github/__toolsnaps__/pull_request_review_write.snap | Updates the aggregate tool schema snapshot. |
| docs/feature-flags.md | Documents the granular parameter. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)pkg/github/pullrequests.go:2108
- Changing this exported function's signature is source-breaking for repositories that import pkg/github. Preserve the existing four-argument ResolveReviewThread API as a compatibility wrapper, and add a separate reason-aware entry point for these tool handlers.
func ResolveReviewThread(ctx context.Context, client *githubv4.Client, threadID string, resolutionReason *string, resolve bool) (*mcp.CallToolResult, error) {
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Balanced
Sorry, something went wrong.
Comment thread
pkg/github/pullrequests.go
Comment thread
pkg/github/pullrequests_granular.go
Comment thread
pkg/github/granular_tools_test.go
Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bf69b12-5131-4382-8c81-8ed1c88fb211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose an optional resolutionReason argument on both review-thread resolution tools and forward it to GraphQL as resolutionReason.
Why
This lets MCP clients record how Copilot Code Review threads were resolved.
Depends on github/github#448461 (commit 191d1c3d49211cd54810c2b1707e28c5ae5460d7).
Fixes # N/A
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
Docs