Remove duplicated *.ncb and *.aps rules from VisualStudio.gitignore - #4912
Open
SurefireStudios wants to merge 1 commit into
Open
SurefireStudios wants to merge 1 commit into
SurefireStudios wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Both rules were already present under "Visual C++ cache files", where they have been since the template was created in 2010 (590e423). A second copy was added in 2019 (e285e4b) under a new "Visual Studio 6 technical files" heading, whose commit described them as "their purpose is unknown for me". Beyond being duplicates, the second heading is inaccurate. Neither file is specific to Visual Studio 6: - *.ncb is the Visual C++ IntelliSense database, used through Visual Studio 2008 and replaced by the SDF database in 2010. The template already lists *.sdf two lines below *.ncb in the "Visual C++ cache files" section, so the pair belongs together there. - *.aps is the binary form of the resource script used by the resource editor. Microsoft documents it for msvc-140 through msvc-180 (Visual Studio 2015 to 2022) and states plainly that it should not be in source control. The genuinely VS6-specific rules added by that commit (*.vbw, *.dsw, *.dsp) are untouched. Behaviour is unchanged: both patterns are still ignored, once each, under the heading that describes them correctly.
ArshVermaGit
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks good to me. The duplicate rules are cleanly removed without affecting existing behavior.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAt least 1 approving review is required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
Visual Studio — specifically the Visual C++ toolset.
Reasons for making this change
VisualStudio.gitignore lists *.ncb and *.aps twice each, which the contribution guidelines ask contributors to avoid.
Both have been in the # Visual C++ cache files section since the template was created in November 2010 (590e423); a second copy was added in July 2019 (e285e4b) under a new # Visual Studio 6 technical files heading, described in that commit as "their purpose is unknown for me".
That heading is also inaccurate, since neither file is specific to Visual Studio 6:
Behaviour is unchanged: both patterns are still ignored, once each, under the heading that describes them correctly.
The genuinely VS6-specific rules from that 2019 commit — *.vbw, *.dsw, *.dsp — are untouched.
I kept this to the one template, so the duplicate *.o / *.elf rules in community/libogc.gitignore are left for a separate PR if wanted.
Links to documentation supporting these rule changes
Merge and Approval Steps