FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update build matrix to reflect Puppet's supported ruby version by kpaulisse · Pull Request #180 · github/octocatalog-diff · GitHub

Update build matrix to reflect Puppet's supported ruby version - #180

Merged
kpaulisse merged 10 commits into
masterfrom
kpaulisse-ruby-version-test-update
Mar 5, 2018
Merged

Update build matrix to reflect Puppet's supported ruby version#180
kpaulisse merged 10 commits into
masterfrom
kpaulisse-ruby-version-test-update

Conversation

kpaulisse commented Feb 28, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

This pull request updates the build matrix to cover Puppet's official puppet-ruby combinations, and updates our requirements documents too. In addition, this bumps the Puppet versions used in our CI to the latest available (today) releases of 4.10.10 and 5.4.0.

This necessitated a change to one of the tests since the error message for a reference validation failure in 5.4.0 is slightly different than 5.0.0. Since #176 deals with reference validation too, I just pulled that one into here too (cc @ahayworth).

ahayworth and others added 9 commits February 14, 2018 10:22
We've noticed a problem at Braintree along the lines of:

  file { '/foo':
    ensure => directory,
  }

  file { '/bar':
    ensure => directory,
    require => File['/foo/'],
  }

This catalog compiles and is valid, but fails validation in octocatalog-diff.
It seems that puppet itself attempts to normalize file resource titles (and indeed
can normalize any type of resource title, given that a methodology exists in the
resource type). See:
https://github.com/puppetlabs/puppet/blob/4.10.x/lib/puppet/type/file.rb#L42

This commit attmepts to mimic that (and lifts the regex directly from the 4.10.x
branch of puppet, because it doesn't matter in puppet 5 since reference validation
is built-in).
kpaulisse self-assigned this Feb 28, 2018
kpaulisse mentioned this pull request Feb 28, 2018
2 tasks
kpaulisse merged commit cb71fb2 into master Mar 5, 2018
kpaulisse deleted the kpaulisse-ruby-version-test-update branch March 5, 2018 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL