Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
There were two cases where CompilationDir wasn't filtering out changes: * if the parameter value is an arbitrary data structure (ie hash, array or mix of both) * if the parameter value is a string containing more than one occurence of the compilation dir It turns out that both can be fixed by just replacing the compilation dirs in both the new and old values with empty strings and comparing what's left. It's probably much slower than the original string-only implementation but covers much more cases as demonstrated by #187 and #188.
I noticed a few mistakes while reading the API documentation, and I couldn't resist to fix them.
Fixes issues with Rubocop checks failing in CI.
Bash location is different from /bin on most non-Linux UNIX systems. Rely on env(1) to find the shell in the user's $PATH.
The commits are referenced in a few places in the test suite, so replace the old latest commit by the new latest one.
We do not always need a full-features bash, plain sh is enougth for some scripts.
This seems to be this problem: travis-ci/travis-ci#8969
…parameter' into 1-5-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests for version 1.5.4 release:
This is now being tested internally at GitHub and if all goes well, will be merged and released on 2018-12-11. I will approve, comment, and give thanks on the above listed PRs upon release.