FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Switch from puppet to openvox by bastelfreak · Pull Request #347 · github/octocatalog-diff · GitHub

/ octocatalog-diff Public

Switch from puppet to openvox - #347

Open
bastelfreak wants to merge 1 commit into
github:masterfrom
bastelfreak:openvox
ConversationCommits (1)ChecksFindingsFiles changed
Open

Switch from puppet to openvox#347
bastelfreak wants to merge 1 commit into
github:masterfrom
bastelfreak:openvox

Conversation

bastelfreak commented Mar 5, 2026

Copy link
Copy Markdown

The puppet gem is dead and won't be updated anymore. And it doesn't work on Ruby 4.

Overview

This pull request replaces puppet with openvox

the puppet gem is dead. It has outdated dependencies, it contains openssl monkey patches that prevents us from using Ruby 4, and it won't receive updates. openvox is the open source successor.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]

Switch from puppet to openvox
c1cc81b 
The puppet gem is dead and won't be updated anymore. And it doesn't work
on Ruby 4.
Copilot AI review requested due to automatic review settings March 5, 2026 10:28
bastelfreak mentioned this pull request Mar 5, 2026
Open
Copilot AI reviewed Mar 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR updates octocatalog-diff’s gem dependencies to replace the deprecated puppet gem with openvox, aiming to keep the project compatible with newer Ruby versions.

Changes:

  • Replace puppet runtime/development dependencies with an openvox runtime dependency.
  • Remove Puppet-version-specific development dependency logic from the gemspec.
  • Delete config/puppet-versions.json (previously used by the gemspec to add conditional dev deps).

Reviewed changes

Copilot reviewed 2 out of 39 changed files in this pull request and generated 3 comments.

File Description
octocatalog-diff.gemspec Switch dependency from puppet to openvox and remove Puppet-version-based dependency injection logic.
config/puppet-versions.json Remove Puppet version matrix config that was consumed by the gemspec.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread octocatalog-diff.gemspec
Comment on lines 31 to 34
s.add_runtime_dependency 'parallel', '>= 1.12.0'
s.add_runtime_dependency 'rugged', '>= 0.25.0b2'
s.add_runtime_dependency 'puppet', '>= 5.5.0'
s.add_development_dependency 'puppet', '>= 5.5.0'
s.add_runtime_dependency 'openvox', '< 9'
s.add_development_dependency 'rspec', '~> 3.4.0'

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

script/bootstrap runs bundle install --local (offline) and the repository’s vendor/cache currently does not include an openvox-*.gem. With this new runtime dependency, bootstrap/CI will fail unless the OpenVox gem is vendored (or --local is removed/changed).

Copilot uses AI. Check for mistakes.
Comment thread octocatalog-diff.gemspec
s.add_runtime_dependency 'rugged', '>= 0.25.0b2'
s.add_runtime_dependency 'puppet', '>= 5.5.0'
s.add_development_dependency 'puppet', '>= 5.5.0'
s.add_runtime_dependency 'openvox', '< 9'

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removing the puppet gem dependency breaks the current bootstrap/CI tooling: script/bootstrap runs bundle binstubs puppet ... and extracts .puppet_version by grepping for puppet in Gemfile.lock, and script/puppet then executes bin/puppet. This PR needs corresponding updates so a bin/puppet binstub is still generated (or scripts are updated to use OpenVox) and the version file is derived from the correct gem/executable.

Suggested change
s.add_runtime_dependency 'openvox', '< 9'
s.add_runtime_dependency 'openvox', '< 9'
s.add_development_dependency 'puppet', puppet_version

Copilot uses AI. Check for mistakes.
Comment thread octocatalog-diff.gemspec
s.add_runtime_dependency 'rugged', '>= 0.25.0b2'
s.add_runtime_dependency 'puppet', '>= 5.5.0'
s.add_development_dependency 'puppet', '>= 5.5.0'
s.add_runtime_dependency 'openvox', '< 9'

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With the removal of the Puppet version matrix block from this gemspec, require 'json', DEFAULT_PUPPET_VERSION, and puppet_version = ... are now unused. Please remove them (or repurpose puppet_version to constrain the openvox dependency) to avoid dead/misleading configuration.

Copilot uses AI. Check for mistakes.

techsk8 commented Jul 22, 2026

Copy link
Copy Markdown

Very much needed! Is this project actually still maintained @bastelfreak ?

bastelfreak commented Jul 24, 2026

Copy link
Copy Markdown
Author

I'm pretty sure it's dead. In the community we recommend https://github.com/voxpupuli/puppet-catalog_diff instead

techsk8 commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

hmm, we're already so used to this tool and we have some scripts on top of it that it would just be easier to patch it and make it work with openvox, so I've done it with #366. Works for us for now.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL