FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Branch Scanning by JennieOhyoung · Pull Request #258 · github/platform-samples · GitHub

/ platform-samples Public

Add Branch Scanning - #258

Open
JennieOhyoung wants to merge 9 commits into
masterfrom
feature_check_branch_commits
ConversationCommits (9)ChecksFindingsFiles changed
Open

Add Branch Scanning#258
JennieOhyoung wants to merge 9 commits into
masterfrom
feature_check_branch_commits

Conversation

JennieOhyoung commented Jul 23, 2019

Copy link
Copy Markdown

I made some changes to this script because:

  1. The commit check is only looking at the default branch and not checking other branches. I added the '-b' option to enable branch scanning.
  2. Some customers are unsure how to get started, so I added a doc link on how to generate a token and specified the date format.

JennieOhyoung commented Jul 23, 2019

Copy link
Copy Markdown
Author

Note: please allow me to do the merging after review. I have a customer currently using the script off of this branch.

primetheus commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

@JennieOhyoung this is really great! Can you update it to use spaces instead of tabs? The formatting of the additions makes some of the additions a bit hard to follow 🙏 🙇

primetheus suggested changes Jul 25, 2019
View reviewed changes

primetheus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the suggested changes feature only allows one line at a time, but lines 119-145, as well as 266-269 have formatting issues as well. Might be a bit of a nit-pick, but helps with the readability when it's all formatted the same 🙇

Comment thread api/ruby/find-inactive-members/find_inactive_members.rb Outdated
Update api/ruby/find-inactive-members/find_inactive_members.rb
3a0819a 
Co-Authored-By: Jared Murrell <primetheus@github.com>
github deleted a comment from Aa88s Aug 12, 2019
jonico reviewed Mar 20, 2020
View reviewed changes
Comment thread api/ruby/find-inactive-members/find_inactive_members.rb
end
# Get all the branches so we can loop through them
if @branches
@client.branches(repo).each do |branch|

jonico Mar 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@JennieOhyoung: looks as if indenting is broken here

primetheus previously approved these changes Mar 20, 2020
View reviewed changes
Comment thread api/ruby/find-inactive-members/find_inactive_members.rb Outdated
primetheus dismissed their stale review March 20, 2020 14:18

misread notification

morongosteve commented Nov 18, 2025

Copy link
Copy Markdown

all approved

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

azizshamim Awaiting requested review from azizshamim
pholleran Awaiting requested review from pholleran
4 more reviewers
jonico jonico left review comments
morongosteve morongosteve approved these changes
siddharthgavit451-arch siddharthgavit451-arch approved these changes
primetheus primetheus left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL