FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update default X-XSS-Protection value to 0 by rzhade3 · Pull Request #479 · github/secure_headers · GitHub

/ secure_headers Public

Update default X-XSS-Protection value to 0 - #479

Merged
rzhade3 merged 3 commits into
mainfrom
update-default-xss-protection
Aug 9, 2024
ConversationCommits (3)ChecksFindingsFiles changed
Merged

Update default X-XSS-Protection value to 0#479
rzhade3 merged 3 commits into
mainfrom
update-default-xss-protection

Conversation

rzhade3 commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

This PR updates the default value of the X-XSS-Protection header to 0. There's further discussion here about the reasons for this: #439.

All PRs:

  • Has tests
  • Documentation updated

Closes #439

rzhade3 requested review from JackMc and vcsjones April 1, 2022 19:00

vcsjones commented Apr 1, 2022

Copy link
Copy Markdown
Member

This is probably a good change to take but likely only for the next major release of this gem - as @oreoshake pointed out this is a breaking change. Maybe we can start gathering some thoughts on what the next major release should look like.

JackMc mentioned this pull request Apr 4, 2022
Closed
JackMc reviewed Apr 4, 2022
View reviewed changes

JackMc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree that this would be a good change and should be merged as part of the next major version. I started a tracking issue to collect all the things that would go into that version: #480.

JackMc removed the request for review from vcsjones April 22, 2022 13:46
lgarron added this to the v7 milestone Jan 4, 2023

richter-alex commented Feb 21, 2023

Copy link
Copy Markdown

Howdy @JackMc! Any updates on when we might be able to expect a new major release being cut with this in it?

rzhade3 merged commit cf56fc9 into main Aug 9, 2024
rzhade3 deleted the update-default-xss-protection branch August 9, 2024 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vcsjones vcsjones approved these changes
boveus boveus approved these changes
+1 more reviewer
JackMc JackMc left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7

Development

Successfully merging this pull request may close these issues.

Should x-xss-protection default to “0” instead of “1; mode=block”

6 participants

Back | FazBrowse Home | New Git URL