FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Avoid uploading eslint sarif for dependabot PR by aeisenberg · Pull Request #3726 · github/vscode-codeql · GitHub

Avoid uploading eslint sarif for dependabot PR - #3726

Merged
aeisenberg merged 2 commits into
mainfrom
aeisenberg/no-upload-sarif
Sep 24, 2024
Merged

aeisenberg merged 2 commits into
mainfrom
aeisenberg/no-upload-sarif

Conversation

aeisenberg commented Sep 23, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Dependabot does not have security-events: write permission.

See github/codeql-action#2485 for the original instance of this problem.

Dependabot does not have `security-events: write` permission.
aeisenberg requested a review from a team as a code owner September 23, 2024 19:15

Copy link
Copy Markdown
Contributor Author

Hmmm...unsure why the CI jobs are failing. Looks like it is failing on main as well. https://github.com/github/vscode-codeql/actions/runs/10994181318/job/30522243194#step:7:95

aeisenberg requested a review from charisk September 24, 2024 02:48

aeisenberg commented Sep 24, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

Bumping the timeout worked.

Feels a little lazy, but if you're ok with it, so am I.

aeisenberg merged commit b6b707e into main Sep 24, 2024
aeisenberg deleted the aeisenberg/no-upload-sarif branch September 24, 2024 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL