Update skeleton-query-wizard.ts - #3994
Merged
aeisenberg merged 1 commit intoApr 8, 2025
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add an `actions` sample database. I chose `github/codeql` since we know it has many complex workflows.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the skeleton query wizard file by adding an "actions" entry to the sample database mapping, using "github/codeql" to represent complex workflows.
- Added a new mapping for "actions" to use "github/codeql"
- Updated the existing query language to database repository map to include the new sample
extensions/ql-vscode/src/local-queries/skeleton-query-wizard.ts:41
- [nitpick] The key 'actions' may be confusing as it does not align with the naming pattern of other language keys. Consider renaming it to something like 'github_actions' to improve clarity and consistency.
actions: "github/codeql",
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The E2E tests have been failing since github/codeql-action#2854 has been merged. |
Sorry, something went wrong.
koesie10
approved these changes
Apr 8, 2025
koesie10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an actions sample database. I chose github/codeql since we know it has many complex workflows.