FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Fix linting that is failing the CI by mtscout6 · Pull Request #400 · github-tools/github · GitHub

WIP: Fix linting that is failing the CI - #400

Closed
mtscout6 wants to merge 3 commits into
github-tools:masterfrom
mtscout6:fix-ci
Closed

WIP: Fix linting that is failing the CI#400
mtscout6 wants to merge 3 commits into
github-tools:masterfrom
mtscout6:fix-ci

Conversation

mtscout6 commented Nov 18, 2016
edited
Loading

Copy link
Copy Markdown
Member

May I suggest that you migrate this repo to an organization and institute protected branch support on master so PRs cannot be merged when the CI is failing?

See: #263

This will allow you to run `mocha -w` without any other special arguments and still get babel compilation
mtscout6 changed the title Fix linting that is failing the CI WIP: Fix linting that is failing the CI Nov 18, 2016

Copy link
Copy Markdown
Member Author

Looks like the mikedeboertest/TestRepo has been deleted which is why a number of the tests are broken. Does anyone know why that repo was deleted?

Copy link
Copy Markdown
Member Author

I recreated the repo for that test user account

Copy link
Copy Markdown
Member Author

Ok, I got hit with a 403 rate limited for the mikedeboertest account. So, I'll need to wait for that rate limit to go down before I can try again.

mathieudutour commented Nov 18, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member Author

@mathieudutour Instead of pushing yet another fork and another module pushed up to npm I'd much rather see #263 happen and just get more people to work together. @michael What is holding this up from getting more people to help with it? I can so two active forks of this project and I'd really hate to side step the team that originally put this promised based wrapper together.

Copy link
Copy Markdown
Member

@mtscout6 @michael does not actively monitor the notifications from this repo. If we want to move this to an org (probably a good idea) we'll need to reach out to him directly.

mathieudutour commented Nov 18, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Indeed, I'd be happy to help.

(I published my fork because I needed some of the opened PRs for a project.)

Copy link
Copy Markdown
Member

great, well I'll reach out and see if we can get the repo moved.

Copy link
Copy Markdown
Member Author

The Issue tests should be fixed now. Still have 10 more failing tests

Copy link
Copy Markdown
Member Author

Nevermind, something is still deleting that repo...

Copy link
Copy Markdown
Contributor

I removed the dependency to that repo in my fork. I'll create a PR soon but there will be lots of changes.

Copy link
Copy Markdown
Contributor

see #401

Copy link
Copy Markdown
Member Author

Closing in favor of #401

mtscout6 closed this Nov 29, 2016
mtscout6 deleted the fix-ci branch November 29, 2016 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL