FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add commit author by j-rewerts · Pull Request #547 · github-tools/github · GitHub

/ github Public

Add commit author - #547

Merged
clayreimann merged 3 commits into
github-tools:masterfrom
j-rewerts:add-commit-author
Apr 10, 2019
ConversationCommits (3)ChecksFiles changed
Merged

Add commit author#547
clayreimann merged 3 commits into
github-tools:masterfrom
j-rewerts:add-commit-author

Conversation

j-rewerts commented Apr 6, 2019

Copy link
Copy Markdown
Member

Closes #546.

The commit function can now accept optional parameters for setting who the author or committer is. See here for GitHub's API on it.

j-rewerts mentioned this pull request Apr 6, 2019
Open

j-rewerts commented Apr 6, 2019

Copy link
Copy Markdown
Member Author

If we merge #544 and #545, all the tests should pass.

j-rewerts commented Apr 9, 2019

Copy link
Copy Markdown
Member Author

@clayreimann Do you want me to merge from upstream master into my branch prior to merging?

clayreimann commented Apr 9, 2019

Copy link
Copy Markdown
Member

@j-rewerts merge or rebase is fine with me. My first instinct is to squash merge for small PRs with more than 1 commit.

codecov-io commented Apr 9, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@64a9223). Click here to learn what that means.
The diff coverage is 80%.

@@            Coverage Diff            @@
##             master     #547   +/-   ##
=========================================
  Coverage          ?   90.79%           
=========================================
  Files             ?       12           
  Lines             ?      413           
  Branches          ?        0           
=========================================
  Hits              ?      375           
  Misses            ?       38           
  Partials          ?        0
Impacted Files Coverage Δ
lib/Requestable.js 94.11% <ø> (ø)
lib/GitHub.js 100% <ø> (ø)
lib/Repository.js 81.3% <100%> (ø)
lib/User.js 94.73% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a9223...d25bc31. Read the comment docs.

j-rewerts force-pushed the add-commit-author branch from d25bc31 to 09f2042 Compare April 9, 2019 22:12

j-rewerts commented Apr 9, 2019

Copy link
Copy Markdown
Member Author

@clayreimann Yeah feel free to squash and merge.

clayreimann merged commit 90fb78b into github-tools:master Apr 10, 2019
This was referenced Jan 12, 2022
Open
Open
This was referenced Feb 10, 2022
Open
Open
enterstudio mentioned this pull request Jan 10, 2023
Open
bluzi mentioned this pull request Jan 10, 2023
Open
Bhanditz mentioned this pull request Jan 10, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clayreimann clayreimann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL