This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix(action): fix unhandled promise rejection - #32
Merged
Wattenberger merged 1 commit intoAug 18, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
this is great, thanks for the PR! |
Sorry, something went wrong.
ageorgou
added a commit
to ageorgou/repo-visualizer
that referenced
this pull request
Aug 22, 2021
Wattenberger
pushed a commit
that referenced
this pull request
Aug 23, 2021
Propagate the fix from #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the unhandled promise rejection when something errors out inside main. An example would be when one of the git commands fail such as pushing to a write protected branch, you would see this message but the action still passes:
It is fixed by using core.setFailed documented here.
Related issues: #2 #9