Added specific test for roughly checking configuration paths. · gitpython-developers/GitPython@dfb0a9c · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit dfb0a9c

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Added specific test for roughly checking configuration paths.

For some reason, I didn't trust the existing one as it tests that code more indirectly. Related to #160

1 parent acd8246 commit dfb0a9c
Copy full SHA for dfb0a9c

3 files changed

+7-2Lines changed: 7 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .gitignore
• git
  • repo
    • base.py
  • test
    • test_repo.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.gitignore‎

Copy file name to clipboardExpand all lines: .gitignore

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -10,6 +10,6 @@ cover/
10	10	/doc/_build
11	11	nbproject
12	12	*.sublime-workspace
13		-
	13	+ .DS_Store
14	14	/*egg-info
15	15	/.tox

Collapse file

‎git/repo/base.py‎

Copy file name to clipboardExpand all lines: git/repo/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -354,7 +354,7 @@ def _get_config_path(self, config_level):
354	354	if config_level == "system":
355	355	return "/etc/gitconfig"
356	356	elif config_level == "user":
357		- config_home = os.environ.get("XDG_CONFIG_HOME") or join(os.environ.get("HOME", '~'), ".config")
	357	+ config_home = os.environ.get("XDG_CONFIG_HOME") or os.path.join(os.environ.get("HOME", '~'), ".config")
358	358	return os.path.expanduser(join(config_home, "git", "config"))
359	359	elif config_level == "global":
360	360	return os.path.normpath(os.path.expanduser("~/.gitconfig"))

Collapse file

‎git/test/test_repo.py‎

Copy file name to clipboardExpand all lines: git/test/test_repo.py

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -365,6 +365,11 @@ def test_config_writer(self):
365	365	pass
366	366	# END for each config level
367	367
	368	+ def test_config_level_paths(self):
	369	+ for config_level in self.rorepo.config_level:
	370	+ assert self.rorepo._get_config_path(config_level)
	371	+ # end for each config level
	372	+
368	373	def test_creation_deletion(self):
369	374	# just a very quick test to assure it generally works. There are
370	375	# specialized cases in the test_refs module

0 commit comments

Comments

0 (0)