FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

First attempt to fix failing test of #1103 by Byron · Pull Request #1104 · gitpython-developers/GitPython · GitHub

Repository navigation

First attempt to fix failing test of #1103 - #1104

Merged
Byron merged 1 commit into
masterfrom
fix-1103
Jan 8, 2021
Merged

Byron merged 1 commit into
masterfrom
fix-1103

Conversation

Byron commented Jan 7, 2021

Copy link
Copy Markdown
Member

However, the test asserts on the provided context to be correct,
which is hard to do in this branch while it's easy to doubt the value
of this.

Lastly, there seems to be no way to ignore errors in git without
muting all output, which is in fact parsed.

Maybe it's possible to ignore errors while parsing the new kind of
error message.
It looks like one would have to parse stderr to understand what happened, maybe a code refactoring could do that.

However, the test asserts on the provided context to be correct,
which is hard to do in this branch while it's easy to doubt the value
of this.

Lastly, there seems to be no way to ignore errors in `git` without
muting all output, which is in fact parsed.

Maybe it's possible to ignore errors while parsing the new kind of
error message.
Byron marked this pull request as draft January 7, 2021 05:33
Byron merged commit 21e21d0 into master Jan 8, 2021
Byron added this to the v3.1.13 - Bugfixes milestone Jan 8, 2021
Byron deleted the fix-1103 branch October 5, 2026 03:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL