Fix inheritance issue at commit.iter_items - #1119
Merged
Byron merged 1 commit intoFeb 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The iterator used to yield Commit() objects, which does not play well with inheritance. Yield cls() instead. Signed-off-by: Yuri Volchkov <yuri@volch.org>
Copy link
Copy Markdown
Author
|
I am not sure the test failure: stderr: 'fatal: unable to connect to localhost: localhost[0: ::1]: errno=Connection refused localhost[1: 127.0.0.1]: errno=Connection refused is related to my changes anyhow... Is that a known issue. Or could someone help me figure out what is wrong? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks a lot for the fix! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
thanks for the quick merge! Are you planning a release soon by any chance? :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.
Signed-off-by: Yuri Volchkov yuri@volch.org