FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GPG signature support on commit object. by sugi · Pull Request #124 · gitpython-developers/GitPython · GitHub

Repository navigation

GPG signature support on commit object. - #124

Closed
sugi wants to merge 2 commits into
gitpython-developers:masterfrom
sugi:gpg-sig-support
Closed

sugi wants to merge 2 commits into
gitpython-developers:masterfrom
sugi:gpg-sig-support

Conversation

sugi commented Oct 7, 2013

Copy link
Copy Markdown
Contributor

I rewrite the patch for GPG signature support with unit test.

This replaces pull request #57 and also fixes issue #110.

Copy link
Copy Markdown

It'll be nice to have this merged at least. GPG signed commits are good!

Copy link
Copy Markdown

What's the current status on this? I've inherited some code that reports git versions of the running system, and it started breaking when we started signing our code.

Copy link
Copy Markdown

FWIW in addition to signed commits there are also signed tags, and further-more when you merge a signed tag recent versions of git will actually include the signed tag itself in the commit created, letting you verify that signature without the tag object itself. Not too many projects do this, but the Linux kernel git repo does.

Marlinc commented Jul 17, 2014

Copy link
Copy Markdown

Can someone fix this pull request?
I don't know Python so I can't.

Byron commented Jul 17, 2014

Copy link
Copy Markdown
Member

I just had a look at this one, and it seems it's not easily mergeable for some reason.

Also, it might not be of any use as branch 0.3 is the one most people are seeing, which will require it to be backported as well.
This pull request was made against master, which changed a lot and is currently entirely unsupported.
However, I will do this with priority, as it clearly is a useful feature with a sound implementation.

shenek commented Jul 17, 2014

Copy link
Copy Markdown

Hi, try to apply it from here http://pastebin.com/729KRw8V
The main issue was that the original code used tabs. The new one uses spaces.

(If the patch still won't apply try to add a space to the end of the last line. Pastebin removed it for some reason...)

Byron commented Jul 17, 2014

Copy link
Copy Markdown
Member

Thanks for the hint !
I just looked at the commandline diff, and for some reason didn't even consider whitespace issues as a possible cause, even though I was the one who applied the transition from tabs to whitespace in the first place.

mrasskazov added a commit to mrasskazov/GitPython that referenced this pull request Sep 8, 2014
Originals:
Pull request "GPG signature support on commit object" gitpython-developers#124 by Tatsuki Sugiura.
gitpython-developers#124
commit 8065d2a
commit 62ecd6c

Copy link
Copy Markdown
Contributor

I have rebased this pull request to current 0.3 and sent new one #189. Please review and and consider to merge.

Byron commented Nov 14, 2014

Copy link
Copy Markdown
Member

I will close this request, as it was already merged into 0.3. In master it is not required, as it is obsolete.
Thanks for your understanding.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL