Repository navigation
Fix timezone parsing functions for non-hour timezones - #1547
Merged
Byron merged 1 commit intoJan 25, 2023
Merged
Byron merged 1 commit into
Byron merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `utctz_to_altz` and `altz_to_utctz_str` functions fail to handle timezones with UTC offsets that are not a multiple of one hour. Rewrite them and add some unit tests. Fixes gitpython-developers#630
Byron
approved these changes
Jan 25, 2023
Byron
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks a million, this is long overdue!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
By the way, I can imagine a round-trip test that runs from -12*3600 to 12 * 3600 and assures that b(a(t)) == t for each second this loop produces. If you are intrigued, maybe submit another PR for that :). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The utctz_to_altz and altz_to_utctz_str functions fail to handle timezones with UTC offsets that are not a multiple of one hour. Rewrite them and add some unit tests.
Fixes #630